fix: continue moving all files in move-github-dotgithub - #1839
Open
github-actions[bot] wants to merge 1 commit into
Open
fix: continue moving all files in move-github-dotgithub#1839github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Use pre-increment for the move counter so set -e does not abort after the first file move. Closes #1838 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 18, 2026
Open
v1v
marked this pull request as ready for review
August 27, 2026 09:12
v1v
approved these changes
Aug 27, 2026
github-actions
Bot
added
the
small_boom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/move-github-dotgithub.shby switching from post-increment to pre-incrementset -efrom exiting after the first moved filegithub/to be movedWhy
Issue #1838 reports that the script exits after moving only one file because
((count++))evaluates to 0 on the first iteration underset -e.Testing
github/Closes #1838
What is this? | From workflow: Trigger Bug Hunter
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.